allegro / ralph / 7886

85%

Pull #3035

travis-ci

Fix `polymorphic_objects` in prefetch related, when base model is filtered

Based on example with Operation and BaseObject: it happened,
that when Operation objects were filtered, `polymorphic_filter`
still contains `Operation.objects.all()`, so all BaseObjects with
particular id(s) which have corresponding Operation (any! not only
the ones filtered in base query) were fetched from DB - but (here
comes the magic!) we were iteration through PKs of objects (BaseObject)
from original query and yield them in the same amount as they occur in
original query (so if there were 3 BaseObjects with PK 1234 in
original query, a lot more objects could be fetched, but only 3
of them were returned, and they might not correspond to current query
of base model (Operation)).

Right now, every fetched object is returned.

24 of 24 new or added lines in 1 file covered. (100.0%)

12248 of 14442 relevant lines covered (84.81%)

0.85 hits per line