834
64%
master: 66%

Ran 24 Apr 2017 03:50PM UTC

Jobs 1

Files 213

Run time 15s

Badge

Embed ▾

pending completion

Build # 834

Build Type

push

travis-ci

Committed by

0x7f454c46

Commit Message

make: keep HOSTCFLAGS clean from target cflags

HOSTCFLAGS are populated with CFLAGS if they are set from environment:
    CFLAGS=-O1 make

But it turns out that =? operator, which sets variable iff it was unset
previously - is recursive expanded operator.
Which means that value of HOSTCFLAGS is evaluated every time it's used.

Which is wrong with the current flaw in Makefile:
    1. it assigns HOSTCFLAGS with CFLAGS from environment as recursive
    2. it assigns target-related options to CFLAGS such as -march.
    3. HOSTCFLAGS are used (with the current code - here they are expanded
       from CFLAGS).

Which results in target-related options supplied to host objects building,
which breaks cross-compilation.
Fix by omitting recursive expansion for HOSTCFLAGS.
Still we need to keep $(WARNINGS) and $(DEFINES) in HOSTCFLAGS.

Link: https://lists.openvz.org/pipermail/criu/2017-April/037109.html
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Reported-by: "Brinkmann, Harald" <Harald.Brinkmann@bst-international.com>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>

Run Details

18930 of 29418 relevant lines covered (64.35%)

90564.76 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	834.1 (TR_ARCH=local GCOV=1)	24 Apr 2017 03:50PM UTC	0	64.35	Travis Job 834.1

Source Files on build 834

Detailed source file information is not available for this build.

0x7f454c46 / criu / 834
64%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 834

0x7f454c46 / criu / 834 64% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 834

0x7f454c46 / criu / 834
64%
master: 66%

README BADGES
x