• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

0x7f454c46 / criu / 834
64%
master: 66%

Build:
Build:
LAST BUILD BRANCH: wip/vdso-kdat
DEFAULT BRANCH: master
Ran 24 Apr 2017 03:50PM UTC
Jobs 1
Files 213
Run time 15s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
834

push

travis-ci

0x7f454c46
make: keep HOSTCFLAGS clean from target cflags

HOSTCFLAGS are populated with CFLAGS if they are set from environment:
    CFLAGS=-O1 make

But it turns out that =? operator, which sets variable iff it was unset
previously - is recursive expanded operator.
Which means that value of HOSTCFLAGS is evaluated every time it's used.

Which is wrong with the current flaw in Makefile:
    1. it assigns HOSTCFLAGS with CFLAGS from environment as recursive
    2. it assigns target-related options to CFLAGS such as -march.
    3. HOSTCFLAGS are used (with the current code - here they are expanded
       from CFLAGS).

Which results in target-related options supplied to host objects building,
which breaks cross-compilation.
Fix by omitting recursive expansion for HOSTCFLAGS.
Still we need to keep $(WARNINGS) and $(DEFINES) in HOSTCFLAGS.

Link: https://lists.openvz.org/pipermail/criu/2017-April/037109.html
Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Reported-by: "Brinkmann, Harald" <Harald.Brinkmann@bst-international.com>
Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>

18930 of 29418 relevant lines covered (64.35%)

90564.76 hits per line

Jobs
ID Job ID Ran Files Coverage
1 834.1 (TR_ARCH=local GCOV=1) 24 Apr 2017 03:50PM UTC 0
64.35
Travis Job 834.1
Source Files on build 834
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #834
  • a4f4c36a on github
  • Next Build on make (#835)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc