783
62%

Ran 24 Apr 2017 03:34AM UTC

Jobs 1

Files 64

Run time 3s

Badge

Embed ▾

pending completion

Build # 783

Build Type

push

travis-ci

Committed by

Roasbeef

Commit Message

server+peer: re-write persistent connection handling

The prior methods we employed to handle persistent connections could
result in the following situation: both peers come up, and
_concurrently_ establish connection to each other. With the prior
logic, at this point, both connections would be terminated as each peer
would go to kill the connection of the other peer. In order to resolve
this issue in this commit, we’ve re-written the way we handle
persistent connections.

The eliminate the issue described above, in the case of concurrent peer
connection, we now use a deterministic method to decide _which_
connection should be closed. The following rule governs which
connection should be closed: the connection of the peer with the
“smaller” public key should be closed. With this rule we now avoid the
issue described above.

Additionally, each peer now gains a peerTerminationWatcher which waits
until a peer has been disconnected, and then cleans up all resources
allocated to the peer, notifies relevant sub-systems of its demise, and
finally handles re-connecting to the peer if it's persistent. This
replaces the goroutine that was spawned in the old version of
peer.Disconnect().

Run Details

7897 of 10681 relevant lines covered (73.94%)

61324.99 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
112	100.0		lnwallet/wallet.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	783.1	24 Apr 2017 03:34AM UTC	0	73.94	Travis Job 783.1

Source Files on build 783

Detailed source file information is not available for this build.

lightningnetwork / lnd / 783
62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 783

lightningnetwork / lnd / 783 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 783

lightningnetwork / lnd / 783
62%

README BADGES
x