cantino / huginn / 3846

92%

push

travis-ci

Rss agent dynamic cleanup (#1733)

* Remove fixed limit of 500 IDs used to figure out which entries are new.
Instead each ID that is checked against the seen_ids gets moved to the top of the list.
IDs that are no longer used in the RSS Feed will end up at the bottom of the seen_ids list end will be removed.

* remove uncommented code line

* fix undefined method `count' for nil:NilClass, in case the first fetch of an rss feed failed or fetched empty rss feed.

changed spec to verify the deletion of old ids by keeping all current ones, not by fixed limit

* revert changes for dynamic cleanup.
Instead made the limit of stored ids configurable. (key: max_ids)
Default limit will remain 500.

* fixed error message.
replaced repeated function call with single call specifying amount.
using options['max_ids'] instead of interpolated['max_ids'] to retrieve setting.

* Rename to remembered_id_count and fix spec

* Update rss_agent.rb

fixed indentation

5 of 5 new or added lines in 1 file covered. (100.0%)

6532 of 7127 relevant lines covered (91.65%)

423.96 hits per line