2675
82%
1.11: 82%

Ran 21 Apr 2017 06:47AM UTC

Jobs 1

Files 269

Run time 14s

Badge

Embed ▾

pending completion

Build # 2675

Build Type

push

travis-ci

Committed by

keradus

Commit Message

bug #2711 FixCommand - fix diff optional value handling (keradus)

This PR was merged into the 2.2 branch.

Discussion
----------

FixCommand - fix diff optional value handling

regression fix for #2554:
```php
new InputOption('diff', '', InputOption::VALUE_OPTIONAL, 'Also produce diff for each file.', 'sbd'),
```
that means:
- 'diff' option may or may not be passed
- when it's passed, value for it is optional
- 'sbd' is default value of `diff` option regardless it is passed or not (!!!)

I guess assumption during creating 2254 was that `sbd` would be only a value for `diff` if one would pass `--diff` (without value). Apparently, it is a value even if one would not pass that option at all, leading to generate diff even without using `--diff` option.

ref https://github.com/symfony/symfony/issues/11572

Commits
-------

5546893d FixCommand - fix diff optional value handling

Run Details

7651 of 8827 relevant lines covered (86.68%)

22.94 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2675.1 (DEPLOY=yes TASK_TESTS_COVERAGE=1)	21 Apr 2017 06:39AM UTC	0	86.68	Travis Job 2675.1

Source Files on build 2675

Detailed source file information is not available for this build.

keradus / PHP-CS-Fixer / 2675
82%
1.11: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2675

keradus / PHP-CS-Fixer / 2675 82% 1.11: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2675

keradus / PHP-CS-Fixer / 2675
82%
1.11: 82%

README BADGES
x