FriendsOfPHP / PHP-CS-Fixer / 9819

82%

master: 93%

push

travis-ci

bug #2711 FixCommand - fix diff optional value handling (keradus)

This PR was merged into the 2.2 branch.

Discussion
----------

FixCommand - fix diff optional value handling

regression fix for #2554:
```php
new InputOption('diff', '', InputOption::VALUE_OPTIONAL, 'Also produce diff for each file.', 'sbd'),
```
that means:
- 'diff' option may or may not be passed
- when it's passed, value for it is optional
- 'sbd' is default value of `diff` option regardless it is passed or not (!!!)

I guess assumption during creating 2254 was that `sbd` would be only a value for `diff` if one would pass `--diff` (without value). Apparently, it is a value even if one would not pass that option at all, leading to generate diff even without using `--diff` option.

ref https://github.com/symfony/symfony/issues/11572

Commits
-------

5546893d FixCommand - fix diff optional value handling

1 of 1 new or added line in 1 file covered. (100.0%)

7651 of 8827 relevant lines covered (86.68%)

22.94 hits per line