228
88%

Ran 21 Aug 2014 05:47PM UTC

Jobs 3

Files 15

Run time 2min

Badge

Embed ▾

pending completion

Build # 228

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

add excludes to Cache.import_tree()

Summary:
When we import files from local overrides, it's very important
that we don't include the `.peru` dir, because a) that could conflict
with the toplevel one and b) the user certainly doesn't want that
anyway. We've been getting that wrong until now, because we've never
tested an overridden module with imports (which would create the
`lastimports` file, otherwise `.peru` is empty).

To fix this, we need a mechanism to exclude specific paths from the
import. (We have `files` to whitelist paths, but that doesn't work for
us here.) This diff adds that new parameter. We'll fix local modules in
a subsequent diff.

We could consider exposing `excludes` to users as a rule field. I could
see legitimate use cases for that. @sean what do you think?

Test Plan:
Turns out `files` was untested at the Cache level. Add a ton
of unit tests for `files` and `excludes`.

Reviewers: sean

Subscribers: sean

Differential Revision: https://phabricator.buildinspace.com/D55

Run Details

766 of 819 relevant lines covered (93.53%)

2.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	228.1	21 Aug 2014 05:48PM UTC	93.53	Travis Job 228.1
2	228.2	21 Aug 2014 05:47PM UTC	93.53	Travis Job 228.2
3	228.3	21 Aug 2014 05:48PM UTC	93.53	Travis Job 228.3

Source Files on build 228

Detailed source file information is not available for this build.

buildinspace / peru / 228
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

buildinspace / peru / 228 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

buildinspace / peru / 228
88%

README BADGES
x