TryGhost / Ghost-Admin / 2140

70%

push

travis-ci

🐛 Fix HTML card not launching in edit mode  (#647)

* replace `isEditing` observers with `didReceiveAttrs` hook

* 🐛 Fix HTML card not launching in edit mode

closes https://github.com/TryGhost/Ghost/issues/8310
- adds `autofocus=true` attribute to `gh-cm-editor` that will use CodeMirror's built-in autofocus behaviour
- set HTML card's launch mode to `edit` and ensure that the `autofocus` attribute is passed
- refactor `gh-cm-editor` for more robust event handling
- re-work `ch-cm-editor` tests to take into account CMs events not being triggered within a single run-loop and to still work when the browser window isn't focused (should fix the random test failures on Travis and the issues where the CM tests will fail locally)

1368 of 2129 branches covered (64.26%)

18 of 18 new or added lines in 1 file covered. (100.0%)

3321 of 4508 relevant lines covered (73.67%)

48.03 hits per line