rwaldron / johnny-five / 2567

92%

push

travis-ci

Add support for CSS color function notation to Led.RGB.color() (#1320)

* Add support for CSS functional notation to Led.RGB.color

Adds support for CSS functional notation (e.g. `"rgb(255, 255, 0)"`) to the `color()` method on the Led.RGB prototype.

Supports:

  - `rgb(r, g, b)`
  - `rgba(r, g, b, a)` where the alpha value in the range 0-1 modifies the color as an intensity function using `RGB.ToScaledRGB()`
  - `rgba(r, g, b)` and `rgb(r, g, b, a)` to comply with the [CSS Color Module Level 4 Draft](https://drafts.csswg.org/css-color/#rgb-functions)

* Add support for functional notation without commas

Also part of the CSS color level 4 spec.

* Fix lint errors

2789 of 3255 branches covered (85.68%)

7237 of 7889 relevant lines covered (91.74%)

1429.33 hits per line