499
85%

Ran 06 Apr 2017 02:53AM UTC

Jobs 2

Files 19

Run time 5s

Badge

Embed ▾

pending completion

Build # 499

Build Type

push

travis-ci

Committed by

keathley

Commit Message

Added tests for Wallaby.Phantom.Driver (#191)

* Added tests for Wallaby.Phantom.Driver

This change tests the interactions between the Wallaby.Phantom.Driver
module and the PhantomJS webdriver API. I wanted to make sure I had test
coverage here so I didn't accidentally break the
serialization/deserialization logic when I start extracting logic to add
a Selenium driver.

Another couple of changes to note:

  * Changed the Content-Type header from "text/json" to
    "application/json". See: http://stackoverflow.com/a/477819
  * Extracted a create_session/2 function in Wallaby.Phantom.Driver that
    only handles the API interaction. This made it much easier to test
    with Bypass. I also used @doc false because I didn't want to expose
    a new public function in the docs.

* Removed unnecessary comments

Run Details

458 of 584 relevant lines covered (78.42%)

26370.41 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	499.1	06 Apr 2017 02:53AM UTC	0	78.42	Travis Job 499.1
2	499.2	06 Apr 2017 02:53AM UTC	0	78.42	Travis Job 499.2

Source Files on build 499

Detailed source file information is not available for this build.

keathley / wallaby / 499
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

keathley / wallaby / 499 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

keathley / wallaby / 499
85%

README BADGES
x