savoirfairelinux / sous-chef / 1818

95%

Pull #719

travis-ci

Fixed #700: redesign meal defaults/schedule UI and backend API

This contains several improvements and cleanups, in order to clariy the confusing behavior that has existed for a long time.
1. In backend, a clear definition on client.meals_default and client.meals_schedule.
   (a) clients.meals_default now returns the database value "as is". The validation logic is moved to its form.
   (b) We now have the distinction between None value and zero value. Zero value means that the client doesn't want, while None value means it is not set.
   (c) Fix tests.
   (d) Fix order creation logic.
2. Use table to view and edit client.meals_default.
3. Replace the confusing {% cell %} and {% size %} tags. Moved the extra template tags to sous_chef package as they are shared throughout the application.
4. Delete unused template files.
5. Delete unused client properties (getters and setters) and related codes, notably the meal defaults that are not stored as client option anymore (see datamigration module).
6. Update Semantic UI and jQuery versions to the latest minor releases.

124 of 124 new or added lines in 9 files covered. (100.0%)

6607 of 6946 relevant lines covered (95.12%)

0.95 hits per line