uber-go / zap / 1691

97%

cron

travis-ci

Open should only return close on success (#396)

Config assumes that Open will always return a close function
which causes a panic when Open returns an error, since it doesn't
return a close function.

We can instead clean up the assumption that we return partial values
on error, and instead use a more common pattern:
 - On success, `err == nil` and all other return values are valid
 - On error, `err != nil` and all other return values are zero values

Fixes #390.

9 of 9 new or added lines in 2 files covered. (100.0%)

2264 of 2326 relevant lines covered (97.33%)

145214.7 hits per line