shakacode / react_on_rails / 3240

0%

push

travis-ci

Use <script type="application/json"> for props and store (#775) for performance

Initial implementation started by https://github.com/eliaslopezgt and then https://github.com/squadette
* Refactor console output to use <script> tag with a certain ID
* Use <script type="application/json"> with JSON content instead of attribute
* Pretty-print JSON in development and testing
* getAttribute() is better, because it handles attributes which are not present.
* Return skip display none to react on rails configuration
* Extract data-js-react-on-rails-store attribute to the const
* Return to_json method call to app_props_server_render to ensure handling the both cases
* Delete unnecessary style method and HIDDEN constant from react component module
* Improve jsonEl parsing to handle props as already converted from JSON to a string
* Move handling props already converted to json string to ruby code
* Escape json from props as json string
* Add test to ensure that even json string props are sanitezed
* Delete test json props because we parse all props to a hash now

13 of 13 new or added lines in 3 files covered. (100.0%)

748 of 764 relevant lines covered (97.91%)

82.63 hits per line