248
100%

Ran 13 Aug 2014 08:08PM UTC

Jobs 11

Files 108

Run time 13min

Badge

Embed ▾

pending completion

Build # 248

Build Type

push

travis-ci

Committed by

trevorrowe

Commit Message

Now requesting S3 url-encode all keys by default.

Amazon S3 supports uploading objects with keys that can not
be safely returned in XML responses, such as ascii 0-10.
These keys cause the SDK to fail when attempting to parse
XML if one such key is present.

To support these keys, S3 accepts a Encoding-Type header. When set,
S3 will url encode all keys in the response XML.

This commit adds a plugin, that sets this request parameter by
default. It then also url-decodes keys automatically before
returning the response data. This makes it so the key handling
is hands-off.

If the user specifies the `:encoding_type` request parameter,
then the plugin is disabled, and the decoding of the keys is
left as an exercise for the user. This is required to be
backwards compatible. This also ensures that if S3 specifies
new encoding types in the future, this will not break.

Fixes #95

Run Details

3463 of 3739 relevant lines covered (92.62%)

751.87 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	248.1 (1.9.3, PURE_RUBY=1, Gemfile)	13 Aug 2014 08:09PM UTC	92.19	Travis Job 248.1
2	248.2 (1.9.3, NOKOGIRI=1, Gemfile)	13 Aug 2014 08:11PM UTC	92.06	Travis Job 248.2
3	248.3 (1.9.3, OX=1 OJ=1, Gemfile)	13 Aug 2014 08:10PM UTC	92.06	Travis Job 248.3
4	248.4 (2.0.0, PURE_RUBY=1, Gemfile)	13 Aug 2014 08:08PM UTC	91.54	Travis Job 248.4
5	248.5 (2.0.0, NOKOGIRI=1, Gemfile)	13 Aug 2014 08:09PM UTC	92.09	Travis Job 248.5
6	248.6 (2.0.0, OX=1 OJ=1, Gemfile)	13 Aug 2014 08:14PM UTC	92.09	Travis Job 248.6
7	248.7 (2.1.2, PURE_RUBY=1, Gemfile)	13 Aug 2014 08:15PM UTC	92.09	Travis Job 248.7
8	248.8 (2.1.2, NOKOGIRI=1, Gemfile)	13 Aug 2014 08:17PM UTC	92.09	Travis Job 248.8
9	248.9 (2.1.2, OX=1 OJ=1, Gemfile)	13 Aug 2014 08:16PM UTC	92.09	Travis Job 248.9
10	248.10 (jruby, PURE_RUBY=1, Gemfile)	13 Aug 2014 08:20PM UTC	91.29	Travis Job 248.10
11	248.11 (jruby, NOKOGIRI=1, Gemfile)	13 Aug 2014 08:21PM UTC	91.2	Travis Job 248.11

Source Files on build 248

Detailed source file information is not available for this build.

aws / aws-sdk-core-ruby / 248
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 248

aws / aws-sdk-core-ruby / 248 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 248

aws / aws-sdk-core-ruby / 248
100%

README BADGES
x