1888
49%

Ran 27 Mar 2017 07:54PM UTC

Jobs 13

Files 120

Run time 8min

Badge

Embed ▾

pending completion

Build # 1888

Build Type

push

travis-ci

Committed by

greg0ire

Commit Message

Prevent error rendering blocks when using shared blocks (#796)

Shared blocks are not linked to pages. Thus, for a shared block, the page
variable is null but still defined.

The default template Block/block_base.html.twig does the following check:
{% if block.page is defined %}.This check is wrong because it returns true
and the following {{ block.page.id }} throws an exception:

Impossible to access an attribute ("id") on a null variable.
500 Internal Server Error - Twig_Error_Runtime

However, when SonataPageBundle is installed and enabled, the template
Block/block_base.html.twig is used as base template also in the admin. In
this case, the page variable is undefined.

Run Details

1738 of 4402 relevant lines covered (39.48%)

16.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1888.1	27 Mar 2017 07:54PM UTC	120	39.48	Travis Job 1888.1
2	1888.2	27 Mar 2017 07:56PM UTC	120	39.48	Travis Job 1888.2
3	1888.3	27 Mar 2017 07:53PM UTC	120	39.48	Travis Job 1888.3
4	1888.4	27 Mar 2017 07:54PM UTC	120	39.29	Travis Job 1888.4
5	1888.5	27 Mar 2017 07:56PM UTC	120	37.01	Travis Job 1888.5
6	1888.6	27 Mar 2017 07:56PM UTC	120	36.99	Travis Job 1888.6
9	1888.9 (COMPOSER_FLAGS="--prefer-lowest")	27 Mar 2017 08:00PM UTC	120	39.43	Travis Job 1888.9
10	*1888.10 (SYMFONY=2.3.)**	27 Mar 2017 07:58PM UTC	120	36.9	Travis Job 1888.10
11	*1888.11 (SYMFONY=2.7.)**	27 Mar 2017 07:58PM UTC	120	36.99	Travis Job 1888.11
12	*1888.12 (SYMFONY=2.8.)**	27 Mar 2017 07:59PM UTC	120	36.99	Travis Job 1888.12
13	*1888.13 (SONATA_CORE=3.)**	27 Mar 2017 07:59PM UTC	120	36.99	Travis Job 1888.13
14	*1888.14 (SONATA_ADMIN=3.)**	27 Mar 2017 08:00PM UTC	120	36.99	Travis Job 1888.14
15	*1888.15 (SONATA_BLOCK=3.)**	27 Mar 2017 08:01PM UTC	120	36.99	Travis Job 1888.15

Source Files on build 1888

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

sonata-project / SonataPageBundle / 1888
49%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1888

sonata-project / SonataPageBundle / 1888 49%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1888

sonata-project / SonataPageBundle / 1888
49%

README BADGES
x