openmrslab / suspect / 114

71%

push

travis-ci

ENH: make spectra first class objects (#43)

* Attempts to introduce inheritance to Suspect by creating an MRSBase class with two subclasses, MRSData and MRSSpectrum. Includes methods in each subclass that convert data to the opposite domain. Delegated adjust_phase() to MRSSpectrum. This structure allows users to work with MRS data in whichever domain they want. Safely deleted mrsdata.py (redundant). Resolves #24
Updated other files as needed to reflect this new inheritance structure
Updated requirements.txt to include pydicom

* Removed an unnecessary __new__ constructor in the MRSData subclass

* Attempts to introduce inheritance to Suspect by creating an MRSBase class with two subclasses, MRSData and MRSSpectrum. Includes methods in each subclass that convert data to the opposite domain. Delegated adjust_phase() to MRSSpectrum. This structure allows users to work with MRS data in whichever domain they want. Safely deleted mrsdata.py (redundant). Resolves #24
Updated other files as needed to reflect this new inheritance structure
Updated requirements.txt to include pydicom

* Removed an unnecessary __new__ constructor in the MRSData subclass

* ENH #24: rebased earlier work to current master

 Resuming work on this enhancement after some time, first
 thing is to rebase it onto the current master and get it to
 pass the unit tests, which this commit does

* ENH #24: added new unit test

Simple new unit test to check that calling spectrum()
and fid() return objects of the correct types

* ENH #24: improving readability

removed some commented code and added docstrings

30 of 30 new or added lines in 3 files covered. (100.0%)

1251 of 1665 relevant lines covered (75.14%)

0.75 hits per line