684
62%

Ran 24 Mar 2017 11:50PM UTC

Jobs 2

Files 0

Run time 3s

Badge

Embed ▾

pending completion

Build # 684

Build Type

push

travis-ci

Committed by

Roasbeef

Commit Message

htlcswitch: add HTLC overflow flow-control via bounded channels

This commit fixes a prior bug which would cause the set of HTLC’s on a
node’s commitment to potentially overflow if an HTLC was accepted or
attempted to be forwarded that but the commitment transaction over the
maximum allowed HTLC’s on a commitment transaction. This would cause
the HTLC to silently be rejected or cause a connection disconnect. In
either case, this would cause the two states to be desynchronized any
pending HTLC’s to be ignored.

We fix this issue by introducing the concept of a bounded channel,
which is a channel in which the number of items send and recevied over
the channel must be balanced in order to allow a new send to succeed
w/o blocking. We achieve this by using a chan struct{} as a semaphore
and decrement it each time a packet it sent, increasing the semaphore
one a packet is received. This creates a channel that we can use to
ensure the switch never sends more than N HTLC’s to a link before any
of the HTLC’s have been settled.

With this bug fix, it’s now once again possible to trigger sustained
bursts of payments through lnd nodes.

Run Details

7140 of 10342 relevant lines covered (69.04%)

4818.96 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
213	100.0		lnwallet/channel.go
262	100.0		channeldb/channel.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	684.1	24 Mar 2017 11:50PM UTC	0	69.04	Travis Job 684.1
2	684.2	24 Mar 2017 11:58PM UTC	0	69.03	Travis Job 684.2

Source Files on build 684

Detailed source file information is not available for this build.

lightningnetwork / lnd / 684
62%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 684

lightningnetwork / lnd / 684 62%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 684

lightningnetwork / lnd / 684
62%

README BADGES
x