bitpay / bitcore-lib / 186

98%

Pull #129

travis-ci

This request does not change any behavior, only clarifies the code for
proper behavior.

- If nSequence (sequenceNumber) of a tx input is the maximum value of an
unsigned integer (0xffffffff), then the input is considered "final".
During transaction validation, the consensus rules will check the value
of nSequence. If NOT equal to 0xffffffff, then proceed to include the
transaction's nLockTime value in further consensusus operations. One
rule is OP_CHECKLOCKTIMEVERIFY. The end result is that if nSequence is
equal to 0xffffffff for a given input, any unlocking script (scriptSig)
containing a OP_CHECKLOCKTIMEVERIFY for that input is rendered useless
and will always evaluate to false. This makes a transaction relying on
the evaluation of OP_CHECKLOCKTIMEVERIFY being true, completely
unspendable under the above conditions.

- This fixes the logic in the interpreter routine for
OP_CHECKLOCKTIMEVERIFY to properly check if an input is final and return
false if this is the case. This also fixes the semantics of isFinal()
for an input to reflect the proper logic.

2079 of 2199 branches covered (94.54%)

28 of 28 new or added lines in 8 files covered. (100.0%)

4729 of 4832 relevant lines covered (97.87%)

988.79 hits per line