deanmalmgren / textract / 346

92%

Pull #139

travis-ci

<a href="https://github.com/deanmalmgren/textract/commit/<a class=hub.com/deanmalmgren/textract/commit/356f507c06282659e0c63c1d15488040e2b7d899">356f507c0<a href="https://github.com/deanmalmgren/textract/commit/356f507c06282659e0c63c1d15488040e2b7d899">&quot;&gt;Fix ShellError.is_not_installed()

ShellError.is_not_installed() was broken in </a><a class="double-link" href="https://github.com/deanmalmgren/textract/commit/<a class="double-link" href="https://github.com/deanmalmgren/textract/commit/ce7bc0ecde56c12a908aae7e454a0fa03236d911">ce7bc0ecd</a>">ce7bc0ecd</a><a href="https://github.com/deanmalmgren/textract/commit/356f507c06282659e0c63c1d15488040e2b7d899">
when it stopped running Popen with the &quot;shell=True&quot; argument. Since
it wasn&#39;t being run through a shell, it was throwing an OSError instead
of running but exiting with an exit code 127.

This is a minimal change so that the ShellError will still work the
same as before, but if we get an OSError we pass in the 127 exit code.
This way if there are still any scenarios where exit code 127 would
be run by the application, it will still work as before.

6 of 6 new or added lines in 1 file covered. (100.0%)

410 of 448 relevant lines covered (91.52%)

0.92 hits per line