14588
3%

Ran 23 Mar 2017 03:33AM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 14588

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

reactions: Fix reacting to messages on streams you're not subscribed to.

We use the same strategy Zulip already uses for starred messages,
namely, creating a new UserMessage row with the "historical" flag set
(which basically means Zulip can ignore this row for most purposes
that use UserMessage rows).  The historical flag is ignored, however,
in determining which users' browsers to notify about new reactions,
and thus the user will get to see the reaction appear when they click
a message (and any reactions other users later add, as well!).

There's still something of a race here, in that if some users react to
a message while the user is looking at the unsubscribed stream but
before the user reacts to that message, those reactions will not be
displayed to that user (so counts will be a bit lower, or something).
This race feels small enough to ignore for now.

Fixes #3345.

Run Details

Jobs

ID	Job ID	Ran	Coverage
1	14588.1 (TEST_SUITE=static-analysis)	23 Mar 2017 03:33AM UTC		Travis Job 14588.1
2	14588.2 (TEST_SUITE=production)	23 Mar 2017 03:45AM UTC		Travis Job 14588.2
3	14588.3 (TEST_SUITE=production)	23 Mar 2017 03:47AM UTC		Travis Job 14588.3
4	14588.4 (TEST_SUITE=frontend)	23 Mar 2017 03:42AM UTC		Travis Job 14588.4
5	14588.5 (TEST_SUITE=frontend)	23 Mar 2017 03:44AM UTC		Travis Job 14588.5
6	14588.6 (TEST_SUITE=backend)	23 Mar 2017 03:46AM UTC	91.05	Travis Job 14588.6
7	14588.7 (TEST_SUITE=backend)	23 Mar 2017 03:51AM UTC	91.13	Travis Job 14588.7

Source Files on build 14588

Detailed source file information is not available for this build.

zulip / zulip / 14588
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14588

zulip / zulip / 14588 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14588

zulip / zulip / 14588
3%

README BADGES
x