mbland / go-script-bash / 624

95%

Pull #168

travis-ci

bats/helpers: Create script before setting PATH

The following test case from `tests/new.bats` was failing on Windows
(using the MSYS2 Bash 4.3.46(2)-release from Git for Windows):

   ✗ new: error if setting permissions fails
     (from function `stub_program_in_path' in file lib/bats/helpers, line 320,
      in test file tests/new.bats, line 268)
       `stub_program_in_path 'chmod' 'printf "ARG: %s\n" "$@"' 'exit 1'' failed
     ARG: 700
     ARG: /tmp/test rootdir/bin/chmod
     ARG: -R
     ARG: u+rwx
     ARG: /tmp/test rootdir

Apparently on this platform, `chmod` wasn't already `hash`-ed, and using
`stub_program_in_path` to stub out `chmod` was causing
`create_bats_test_script` to look up `chmod` in `PATH` andinvoke the
stub script itself.

The fix: call `create_bats_test_script` before setting `PATH`. The
existing `stub_program_in_path for testing external program` test case
from `tests/bats-helpers.bats` now uses `chmod` for its example program
instead of `git`, which reproduced the original failure and verifies its
fix.

158 of 158 new or added lines in 4 files covered. (100.0%)

2720 of 2879 relevant lines covered (94.48%)

244.14 hits per line