TryGhost / Ghost-Admin / 1917

70%

push

travis-ci

🎨 synchronous settings service

no issue
- adds `settings` service that acts as a proxy to the singular settings model with methods to fetch and reload, also prevents accidentally loading only some settings types which has caused problems in the past
- updates app boot, signin, and signup processes to fetch settings ensuring that any part of the app can grab settings synchronously if needed
- removes `timeZone` service, it's no longer needed as we can grab `settings.activeTimezone` directly
- replaces all store queries for the settings model with appropriate `settings` methods
- refactors `apps/*` routes/controllers, they had become a little convoluted with the way they were dealing with settings and the new service helped to clean that up

1357 of 2007 branches covered (67.61%)

3185 of 4233 relevant lines covered (75.24%)

64.11 hits per line