keradus / PHP-CS-Fixer / 2564
94%
1.11: 82%

LAST BUILD BRANCH: master
DEFAULT BRANCH: 1.11
Ran
Jobs 1
Files 258
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2564

push

travis-ci

keradus 
minor #2500 Configuration resolver (julienfalque, SpacePossum, keradus)

This PR was merged into the 2.2-dev branch.

Discussion
----------

Configuration resolver

Implements #2482 using `symfony/options-resolver` component.

Configurable fixers implement a new `ConfigurationDefinitionFixerInterface` that extends `ConfigurableFixerInterface` to add a `defineConfiguration()` method. This method must return an `OptionsResolver` instance that defines the configuration options. The interface is temporary (thus deprecated) and to be merged into `ConfigurableFixerInterface` in 3.0.

A few deprecations are introduced: some fixers can be configured by passing a list of strings, e.g. `['foo', 'bar']` but the `symfony/options-resolver` component is not designed for this. In such case, passing the list as the root configuration array is deprecated and a new dedicated option has been created to pass the list, e.g. `['option' => ['foo', 'bar']]`. This also allows to add new options to these fixers in the future. Fixers that handle such configuration will automatically convert the passed array and trigger a deprecation notice. Also, as `symfony/options-resolver` only deals with arrays, passing `NULL` to set the default configuration is deprecated, an empty array must be passed instead.

**Fix command help, before:**

![fix-help-old](https://cloud.githubusercontent.com/assets/1736542/22863087/a17da838-f13a-11e6-9991-68cc8d9562f2.png)

**Fix command help, after:**

![fix-help-new](https://cloud.githubusercontent.com/assets/1736542/22863088/a19e8134-f13a-11e6-80a2-209da5129814.png)

**Describe command, before:**

![describe-old](https://cloud.githubusercontent.com/assets/1736542/22863090/a6f5906e-f13a-11e6-8019-5b768cff43ec.png)

**Describe command, after:**

![describe-new](https://cloud.githubusercontent.com/assets/1736542/22863091/a9ebdc10-f13a-11e6-945a-9f84de1fdc4e.png)

See also the [new README file](https://github.com/julienfalque/PHP-CS-Fixer/blob/configuration-resolver/README.rst).

Commits
-------

852339d FixerConfiguration - better Resolver creation
54cb58b FixerConfiguration - strictify and simplify
354b88f FixerConfiguration - code grooming
28f34da FixerConfiguration - introduce component

7762 of 8468 relevant lines covered (91.66%)

431.58 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2564.1 (DEPLOY=yes TASK_TESTS_COVERAGE=1) 0
91.66
 Travis Job 2564.1
Source Files on build 2564
Detailed source file information is not available for this build.