14303
3%

Ran 19 Mar 2017 09:13PM UTC

Jobs 7

Files 357

Run time 32min

Badge

Embed ▾

pending completion

Build # 14303

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Fix bugs with handling of the empty narrow.

An empty narrow (ie, the home view) can be represented in code as either
`None` or `[]` but we had incorrect handling that failed to fully
properly deal with either case.

(1) In `get_stream_name_from_narrow`, we failed to deal with `None` by
trying to always iterate over `narrow`.
(2) In several other places, we failed to deal with `[]` by explicitly
checking `if narrow is None` or `if narrow is not None`. Changing these
to truthiness checks should work for both the `None` and `[]` cases.

Run Details

28832 of 31629 relevant lines covered (91.16%)

1.82 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	14303.1 (TEST_SUITE=static-analysis)	19 Mar 2017 09:13PM UTC		Travis Job 14303.1
2	14303.2 (TEST_SUITE=production)	19 Mar 2017 09:27PM UTC		Travis Job 14303.2
3	14303.3 (TEST_SUITE=production)	19 Mar 2017 09:30PM UTC		Travis Job 14303.3
4	14303.4 (TEST_SUITE=frontend)	19 Mar 2017 09:25PM UTC		Travis Job 14303.4
5	14303.5 (TEST_SUITE=frontend)	19 Mar 2017 09:32PM UTC		Travis Job 14303.5
6	14303.6 (TEST_SUITE=backend)	19 Mar 2017 09:45PM UTC	91.08	Travis Job 14303.6
7	14303.7 (TEST_SUITE=backend)	19 Mar 2017 09:45PM UTC	91.16	Travis Job 14303.7

Source Files on build 14303

Detailed source file information is not available for this build.

zulip / zulip / 14303
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14303

zulip / zulip / 14303 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 14303

zulip / zulip / 14303
3%

README BADGES
x