ic-labs / django-icekit / 711

74%

Pull #217

travis-ci

Use public-read for S3-enabled storage of thumbnails by default

When the `ENABLE_S3_MEDIA` setting is applied, continue to use "private"
S3 storage for media assets by default, but switch to using "public"
S3 storage for thumbnails generated by the thumbnailing system.

Here "private" storage means that images are only accessible through
time-limited signed S3 URLs, while "public" means that thumbnails will
be accessible through non-time-limited standard S3 URLs and the
thumbnail images will be stored with the `public-read` ACL behind the
scenes.

As part of this change, the `S3DefaultStorage` storage class is renamed
to `S3DefaultPrivateStorage` to be explicit (the original class name
remains available for backwards-compatibility) and the new
`S3DefaultPublicStorage` class is added.

6 of 6 new or added lines in 2 files covered. (100.0%)

3934 of 5397 relevant lines covered (72.89%)

0.73 hits per line