GoogleCloudPlatform / cloud-trace-nodejs / 1829

96%

push

travis-ci

Ensure http response streams are paused (#438)

Responses returned by http#request are yielded in paused mode. By
attaching a 'data' listener to the request the http instrumentation was
switching the stream to flowing mode which could cause the request to
drain before the calling framework had a chance to attach their own
listeners.

This also removes a test for tracking span duration for http requests
with responses that were never checked. We are actually not able to
properly close spans in this case without changing the behavior of the
requests so this test should not pass.

Fixes #437 

PR-URL: https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/438

461 of 535 branches covered (86.17%)

7 of 7 new or added lines in 1 file covered. (100.0%)

1260 of 1308 relevant lines covered (96.33%)

2425.43 hits per line