openmrs / openmrs-core / 5059

65%

Pull #2069

travis-ci

TRUNK-5114 Using different logging implementations instead of facade

we exclude the apache commons-logging dependency coming from springframework
and configure the slf4j facade with the log4j implementation but still
use commons-logging or log4j directly.

* replace usages by using the slf4j facade
* add "org.apache.commons.logging" to checkstyle's IllegalImport rule
so we get notified of anyone trying to use it
* replace log.fatal("message", exception)

with

log.error(MarkerFactory.getMarker("FATAL"), "message", e);

since slf4j does not provide the level FATAL and suggests the use of
markers instead

283 of 283 new or added lines in 227 files covered. (100.0%)

18163 of 32459 relevant lines covered (55.96%)

0.56 hits per line