broadinstitute / firecloud-orchestration / 2131
64%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 69
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2131

push

travis-ci

web-flow 
GAWB-1618, GAWB-1477: Implement new NIH link expiration logic, eliminate ProfileClient (#381)

* implement new NIH link expiration logic 
* refactor ProfileClient (by getting rid of it)
* refactor NihService
* alter error handling in HttpThurloeDAO
* refactor unit tests for NIH related code

104 of 104 new or added lines in 12 files covered. (100.0%)

1330 of 2062 relevant lines covered (64.5%)

0.65 hits per line

Uncovered Changes

Lines Coverage ∆ File
22
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpThurloeDAO.scala
12
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/utils/RestJsonClient.scala
4
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpRawlsDAO.scala
3
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/FireCloudServiceActor.scala
3
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/service/NihService.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/model/ErrorReport.scala

Coverage Regressions

Lines Coverage ∆ File
5
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/utils/DateUtils.scala
5
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/model/Profile.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/ElasticSearchDAOQuerySupport.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/service/TSVFileSupport.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/utils/RestJsonClient.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/service/FireCloudDirectives.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/HttpClient.scala
1
100.0
 src/main/scala/org/broadinstitute/dsde/firecloud/core/GetEntitiesWithType.scala
Jobs
ID Job ID Ran Files Coverage
1 2131.1 0
64.5
 Travis Job 2131.1
Source Files on build 2131
Detailed source file information is not available for this build.