TryGhost / Ghost-Admin / 1813

70%

push

travis-ci

🎨 refactor signin screen to use ember-concurrency & gh-task-button (#571)

refs https://github.com/TryGhost/Ghost/issues/7865
- convert all signin related actions to ember-concurrency tasks and consolidate in the signin controller rather than spread across controller+route
- add `successClass` and `failureClass` params to `gh-task-button` that can be used to override the default success/failure button classes
- prevent clicks on `gh-task-button` from triggering form actions (this behaviour should never be necessary, task buttons should either be separate to the form as in the "forgot?" button or the form action performs the same task and can be triggered by a standard form submit)

1373 of 1997 branches covered (68.75%)

55 of 55 new or added lines in 2 files covered. (100.0%)

3191 of 4224 relevant lines covered (75.54%)

65.67 hits per line