Netflix / security_monkey / 808

68%

push

travis-ci

[secmonkey] Fix justification preservation bug (#564)

Type: general-bugfix

Why is this change necessary?
Any item configuration change (ephemeral or non-ephemeral) causes
Security Monkey to remove existing audit issues, which in turn also
removes and justifications on said issues.  While audit issues are
re-added during the next audit, justifications are lost.

Adding test coverage for watcher class when
there are changes, no changes, and ephemeral
changes.

This change addresses the need by:
Ensuring audit issues are preserved when config changes are detected for
any item.

Potential Side Effects:
No known side effects

92 of 92 new or added lines in 2 files covered. (100.0%)

5396 of 9592 relevant lines covered (56.26%)

0.56 hits per line