763
94%
master: 91%

Ran 03 Mar 2017 05:40PM UTC

Jobs 2

Files 28

Run time 29s

Badge

Embed ▾

pending completion

Build # 763

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Use negative values for implicit field indices (#249)

The Apache Thrift compiler auto-assigns negative values (starting at -1)
to fields with implicit indices. This changes our code to do the same.
Because field identifiers are serialized on the wire, it's important for
our implementations to match in this regard.

This also moves our implicit identifier warning directly into the
parser. This was the only warning being generated from the higher level
Thrift.Parser code; all other error conditions raise exceptions. This
also lets us remove the now-unused Thrift.Parser.Shell module.

The only downside to moving the warning into the parser is that we lose
a little context (the name of the parent struct), but because we now
include a line number and this is such a rare case, this feels like a
reasonable trade-off.

Run Details

638 of 680 relevant lines covered (93.82%)

685.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	763.1 (THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker)	03 Mar 2017 05:40PM UTC	0	93.82	Travis Job 763.1
2	763.2 (THRIFT=${TRAVIS_BUILD_DIR}/ci/thrift-docker)	03 Mar 2017 05:41PM UTC	0	93.82	Travis Job 763.2

Source Files on build 763

Detailed source file information is not available for this build.

pinterest / elixir-thrift / 763
94%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 763

pinterest / elixir-thrift / 763 94% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 763

pinterest / elixir-thrift / 763
94%
master: 91%

README BADGES
x