frictionlessdata / dpr-api / 268

DEFAULT BRANCH: master
Ran
Jobs 1
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
268

push

travis-ci

web-flow 
Merge pull request #253 from subhankarb/dpr-api-248

[refactor][l]: Refactor to converge our API with openspending conductor API.

We want to converge API of both dpr-api and os-conductor. The epic frictionlessdata/dpr-api#249 addressed all the changes we wanted to make so that dpmpy works with both the APIs.

In epic frictionlessdata/dpr-api#249 we mentioned three issues that is related to dpr-api.

- #248 Create /api/bitstore/authorize endpoint. The Commit 136899e43 contains the changes.
  - Previously our url pattern was `{api}/{publisher}/{package}` so we always get publisher and package information. That is why writing annotation was easy. But with `{api}/bitstore/authorize` we need to get publisher and package information from request body. So i am separating the is_authorize logic from annotation and put it in separate method, so that we can call it from controller.
  - Added model `FileData`. In older implementation we had only one s3 url call. But now we have list of files and have to generate a structured json response. That is why separating json building logic from controller is better. It is more testable.
  - Added a method to check datapackage already exists for validation.
  - Added related tests.

- #250 Use 'Auth-Token' instead of 'Authentication' header. The commit f356a6b6c contains the changes.
  - Add additional check for jwt token for header key 'Auth-Token' and remove `bearer` from token prefix.

- #251 Change upload finalization API. The commit 9ae8201c3  contains the changes.
  - Update `{api}/{publisher}/{package}/finalize` API to `{api}/upload`
Jobs
ID Job ID Ran Files Coverage
1 268.1 (FLASK_CONFIGURATION=test) 0
Travis Job 268.1
Source Files on build 268
Detailed source file information is not available for this build.