274
65%
master: 83%

Ran 28 Feb 2017 01:58PM UTC

Jobs 1

Files 9

Run time 0s

Badge

Embed ▾

pending completion

Build # 274

Build Type

push

travis-ci

Committed by

xlr-8

Commit Message

autoscaling: add extra tests to methods

The following methods should now also be covered by tests:
 * TestPropagatedInstance
 * TestGetOnDemandInstanceInAZ
 * TestGetAnyOnDemandInstance
 * TestGetAnySpotInstance
 * TestReplaceOnDemandInstanceWithSpot

Some methods have been modified to be easier to test (return objects,
return errors, etc). One has been renamed to be more logical with the
other similar methods:

 -func (a *autoScalingGroup) findOndemandInstanceInAZ(az *string) *instance {
 +func (a *autoScalingGroup) getOnDemandInstanceInAZ(az *string) *instance {

While some have been simplified, by merging and/or removing some
pieces of unecessary code, that's the case for:
 * (merged) propagatedInstanceTags & filterTags
 * (removed) getAnyInstances (unused),
 * (modified) replaceOnDemandInstanceWithSpot to return errors

Their respective behavior should not have been modified though.

Run Details

871 of 1336 relevant lines covered (65.19%)

4.79 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	274.1	28 Feb 2017 01:58PM UTC	0	65.19	Travis Job 274.1

cristim / autospotting / 274
65%
master: 83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 274

cristim / autospotting / 274 65% master: 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 274

cristim / autospotting / 274
65%
master: 83%

README BADGES
x