m3db / m3cluster / 734
86%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 24
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
734

push

travis-ci

web-flow 
[heartbeat] Store instance proto data in hb store (#89)

* Advertisement: add PlacementInstance to type

* [heartbeat] Store instance proto data in hb store

As we move to a model where the Heartbeat can be used for selecting
placement candidates from a standby pool in addition to just maintaining
IDs of alive instances, we need to store a bit more state in the
heartbeat store along with just instance ID. This modifies the
`heartbeat.Store` interface to accept a `PlacementInstance` object
describing the instance that is heartbeating and store the
protobuf-serialized version of the instance in the heartbeat store.

* [heartbeat] Get: return deserialized instances

Now that the values stored in etcd for heartbeats are proto-serialized
`services.PlacementInstance`s, return the deserialized instances when
querying the heartbeat store.

* [services] style cleanup from PR feedback

* [proto] move conversion functions to util pkg

* [heartbeat] change Get() function back to ids only

* [heartbeat] tests for GetInstances

* [heartbeat] Move Store interface to top-level pkg

* [services] Add HeartbeatStore() func to access hb

* [heartbeat] pass ServiceID type to heartbeat funcs

They need a bit more context (specifically the environment field) to
construct the etcd keys.

* [services] HeartbeatStore -> HeartbeatService

* [proto] generated/proto/util -> proto/util

* [proto] Move Metadata proto funcs to proto/util

* [heartbeat] Only pass zone to HeartbeatService

* [heartbeat] Include default environment

* [heartbeat] Switch back to ServiceID argument

* [heartbeat] Allow empty env in etcd keys

* [heartbeat] tie ServiceID to HB svc at creation

* [services] Add regression tests for cache keys

Used in heartbeat store and watches store

3189 of 3551 relevant lines covered (89.81%)

117237.16 hits per line

Jobs
ID Job ID Ran Files Coverage
1 734.1 (TEST_TIMEOUT_SCALE=20) 0
89.81
 Travis Job 734.1
2 734.2 (PACKAGE=github.com/m3db/m3cluster) 0
89.66
 Travis Job 734.2
Source Files on build 734
Detailed source file information is not available for this build.