159
61%

Ran 25 Feb 2017 05:01AM UTC

Jobs 1

Files 13

Run time 1s

Badge

Embed ▾

pending completion

Build # 159

Build Type

push

travis-ci

Committed by

bradleyfalzon

Commit Message

Fix two slice out of bounds bugs when deduplicating comments

The first would occur because we were manipulating the slice in place
and when there's multiple issues, a slice out of bounds or the wrong
issue could be removed. Fixed by starting at the end of slice and
working to the start.

The second issue could occur when there are already duplicate
comments, if an issue matches an exiting comment, remove it then stop
checking for more duplicate comments for that issue. Removing it again
could remove the wrong issue or cause a slice out of bounds exception.

Run Details

555 of 897 relevant lines covered (61.87%)

1.52 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	159.1 (GOOGLE_APPLICATION_CREDENTIALS=/tmp/gcloud-GopherCI-dev.json)	25 Feb 2017 05:01AM UTC	0	61.87	Travis Job 159.1

Source Files on build 159

Detailed source file information is not available for this build.

bradleyfalzon / gopherci / 159
61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 159

bradleyfalzon / gopherci / 159 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 159

bradleyfalzon / gopherci / 159
61%

README BADGES
x