3080
88%

Ran 23 Feb 2017 06:57AM UTC

Jobs 4

Files 44

Run time 2min

Badge

Embed ▾

pending completion

Build # 3080

Build Type

Pull #588

travis-ci

Committed by

web-flow

Commit Message

Fix flaky test TestInboundConnection

TestInboundConnection verifies that the InboundConnection returns the
right connection. However when the test was run with a relay, there was
a race that could cause the test to fail.

We have a server channel and a relay, and the test called the server
through the relay, so we had:
server --C1--> relay --C?--> server

The relay had a race between whether it would use the incoming
connection from the server to send the call back, or creating a new
connection. When the connection was reused, the test passed since the
relay responds with the host:port on inbound connections. However when
the relay creates a new connection, it hides the host:port on outbound
connections, and so the server would see an ephemeral host:port and this
would cause the test to fail:
https://travis-ci.org/uber/tchannel-go/jobs/204481657

Updated the test to use a separate channel for making calls instead of
a single channel calling itself. Also disable relays to avoid races.

Pull Request Pull Request #588: Fix flaky test TestInboundConnection

Run Details

4263 of 4879 relevant lines covered (87.37%)

12182.0 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	83.33	-0.46%	connection.go
6	83.05	-2.03%	mex.go
18	81.2	-7.69%	outbound.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	3080.1	23 Feb 2017 06:57AM UTC	43	87.12	Travis Job 3080.1
2	3080.2	23 Feb 2017 06:58AM UTC	43	87.0	Travis Job 3080.2
3	3080.3	23 Feb 2017 06:58AM UTC	43	87.14	Travis Job 3080.3
4	3080.4	23 Feb 2017 06:59AM UTC	43	87.18	Travis Job 3080.4

Source Files on build 3080

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 3080
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3080

uber / tchannel-go / 3080 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3080

uber / tchannel-go / 3080
88%

README BADGES
x