3079
88%
dev: 88%

Ran 23 Feb 2017 06:55AM UTC

Jobs 4

Files 44

Run time 56s

Badge

Embed ▾

pending completion

Build # 3079

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Fix flaky test TestInboundConnection

TestInboundConnection verifies that the InboundConnection returns the
right connection. However when the test was run with a relay, there was
a race that could cause the test to fail.

We have a server channel and a relay, and the test called the server
through the relay, so we had:
server --C1--> relay --C?--> server

The relay had a race between whether it would use the incoming
connection from the server to send the call back, or creating a new
connection. When the connection was reused, the test passed since the
relay responds with the host:port on inbound connections. However when
the relay creates a new connection, it hides the host:port on outbound
connections, and so the server would see an ephemeral host:port and this
would cause the test to fail:
https://travis-ci.org/uber/tchannel-go/jobs/204481657

Updated the test to use a separate channel for making calls instead of
a single channel calling itself. Also disable relays to avoid races.

Run Details

4273 of 4879 relevant lines covered (87.58%)

12182.62 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3079.1	23 Feb 2017 06:55AM UTC	87.19	Travis Job 3079.1
2	3079.2	23 Feb 2017 06:55AM UTC	87.0	Travis Job 3079.2
3	3079.3	23 Feb 2017 06:55AM UTC	87.3	Travis Job 3079.3
4	3079.4	23 Feb 2017 06:56AM UTC	86.95	Travis Job 3079.4

Source Files on build 3079

Detailed source file information is not available for this build.

uber / tchannel-go / 3079
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3079

uber / tchannel-go / 3079 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3079

uber / tchannel-go / 3079
88%
dev: 88%

README BADGES
x