alphagov / digitalmarketplace-content-loader / 252

99%

master: 99%

push

travis-ci

Taxonomy (category tree) implementation - simplification

  - https://trello.com/c/y79rP1KA/197-suppliers-choose-a-category-backend
  - less is more - don't need to build another tree structure
  - also tidy up inheritance for summary, multiple inheritance avoided
    as not needed

Explanation of why we are storing the parent values:

  - really, these additional categories are a denormalization. Arguably,
    the frontend should just assume that they are selected - the place
    they actually need to be selected is in the search engine;
  - however, the indexer doesn't have access to the tree at the moment,
    so moving the denormalization there is rather hard;
  - the next best place to put this might then be the API, because that
    would ensure a consistent view on the data. But that would require
    teaching the API about this as a special field, and no other fields
    get processing applied - either the data posted in is accepted, or
    not (i.e. we only have validation, nothing beyond that). And again,
    the API doesn't currently have access to the original framework data,
    so even if we wanted to have the additional categories added there,
    it's hard in the current structure.
  - that leaves us with having to do the denormalization in the frontends
    (i.e. in the content loader)
  - having the API validate that the denormalization was applied means
    duplicating that content loader logic into the API, and again we don't
    actually have the data available that would allow us to do that anyway...
  - and therefore data validly posted to the API may not have the
    denormalization applied (i.e. if someone posted to the API via some other
    method than the content loader).
  - and that's weird, but we can't do anything about it, and weird stuff
    shouldn't be silent, so here we are.

12 of 12 new or added lines in 1 file covered. (100.0%)

771 of 777 relevant lines covered (99.23%)

1.98 hits per line