12768
3%

Ran 18 Feb 2017 12:32AM UTC

Jobs 7

Files 332

Run time 12min

Badge

Embed ▾

pending completion

Build # 12768

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Simplify and speed up stream deactivation.

This is a fairly risky, invasive change that speeds up
stream deactivation by no longer sending subscription/remove
events for individual subscribers to all of the clients who
care about a stream.  Instead, we let the client handle the
stream deactivation on a coarser level.

The back end changes here are pretty straightforward.

On the front end we handle stream deactivations by removing the
stream (as needed) from the streams sidebar and/or the stream
settings page.  We also remove the stream from the internal data
structures.

There may be some edge cases where live updates don't handle
everything, such as if you are about to compose a message to a
stream that has been deactivated.  These should be rare, as admins
generally deactivate streams that have been dormant, and they
should be recoverable either by getting proper error handling when
you try to send to the stream or via reload.

Run Details

26529 of 29538 relevant lines covered (89.81%)

1.79 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	12768.1 (TEST_SUITE=static-analysis)	18 Feb 2017 12:32AM UTC		Travis Job 12768.1
2	12768.2 (TEST_SUITE=production)	18 Feb 2017 12:38AM UTC		Travis Job 12768.2
3	12768.3 (TEST_SUITE=production)	18 Feb 2017 12:39AM UTC		Travis Job 12768.3
4	12768.4 (TEST_SUITE=frontend)	18 Feb 2017 12:36AM UTC		Travis Job 12768.4
5	12768.5 (TEST_SUITE=frontend)	18 Feb 2017 12:39AM UTC		Travis Job 12768.5
6	12768.6 (TEST_SUITE=backend)	18 Feb 2017 12:40AM UTC	89.72	Travis Job 12768.6
7	12768.7 (TEST_SUITE=backend)	18 Feb 2017 12:44AM UTC	89.81	Travis Job 12768.7

Source Files on build 12768

Detailed source file information is not available for this build.

zulip / zulip / 12768
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12768

zulip / zulip / 12768 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12768

zulip / zulip / 12768
3%

README BADGES
x