GoogleCloudPlatform / google-cloud-java / 3080

72%

Pull #1625

travis-ci

pubsub: fix testModifyAckDeadline flaking, maybe

Previously MessageDispatcher starts off with deadline duration of 0.
Since we need to extend deadline before the time is up,
the client extends deadline a little before the deadline.
This translates to scheduling deadling extension "in the past".

In turn, this causes tasks to be run -- and new tasks scheduled --
without explicit calls to advance the time on the fake clock.
So, when the test code actually advance the fake clock,
it runs more tasks than it wants to.

This PR conservatively sets the initial deadline duration to 10 seconds.
This is already the default in streaming version.

5 of 5 new or added lines in 3 files covered. (100.0%)

20034 of 24698 relevant lines covered (81.12%)

119.19 hits per line