jan-molak / serenity-js / 113

90%

push

travis-ci

refactor(core): Domain classes represent the domain concepts better

- `Performable` is really an `Activity` that an `Actor` can perform, therefore it should be called as such.
- What used to be an `Activity` is now a `RecordedActivity`. `RecordedActivity` is just a "tiny type", that captures the name of the real `Activity` and works alongside with `Outcome` to capture the result and other meta data related to the performance.
- To make the model consistent, `Scene` is now a `RecordedScene`
- To help distinguish `RecordedActivity` related to a `Task` and `Interaction`, the `@step()` annotation can now take an optional second arugment `ActivityType.Task` or `ActivityType.Interaction`. A `@step` that doesn't specify its type is considerd to be of type `Task` by default as 90% of time you'll be writing Tasks not Interactions.
- The distinction between a `RecordedTask` and `RecordedInteraction` will help to make the configuration of the `Photographer` more fine-grained, so that we could for example tell it to only capture screenshots of interactions rather than all the tasks. This will also help to enable the granularity needed for #18.
- `See` and `CompareNotes` are now `Interactions` rather than generic `Activities` (pretending to be `Tasks`), as performing an assertion is also an interaction with the system. No need for special treatment of those two classes.
- The `Interaction` interface is also corrected to allow for `Actors` that `UseAbilities` but also `AnswerQuestions`

Those changes should not affect the consumers of the Serenity/JS APIs and will help tackle the tech debt before it spreads ;-)

Enables #18, #22, #23

93 of 93 new or added lines in 27 files covered. (100.0%)

1244 of 1271 relevant lines covered (97.88%)

35.22 hits per line