ReactiveX / rxjs / 4196

97%

Pull #2360

travis-ci

fix(Subscription): fold ChildSubscription logic into Subscriber to prevent operators from leaking ChildSubscriptions.

The addition of ChildSubscription to fix #2244 accidentally introduced a different memory leak. Most operators that add and remove inner Subscriptions store the inner Subscriber instance, not the value returned by Subscription#add. When they try to remove the inner Subscription manually, nothing is removed, because the ChildSubscription wrapper instance is the one added to the subscriptions list.

Fixes #2355

76 of 76 new or added lines in 8 files covered. (100.0%)

6515 of 6668 relevant lines covered (97.71%)

669.93 hits per line