yabwe / medium-editor / 3169

94%

Pull #1258

travis-ci

Only add schemes to URLs with hostnames

Fixes: https://github.com/yabwe/medium-editor/issues/1250

This changes the way a scheme is prefixed to a URL when linkValidation
is on. Previously any URL that did not match the scheme regex would be
prefixed with 'http://' which meant that an absolute path such as '/'
would be changed to 'http:///'

This changes it so that the 'http://' is only prefixed if the first part
of the path looks like a hostname, which allows absolute paths to be
unchanged and most relative paths to be unchanged.

I say most as a path such as "test.txt" would be matched as a hostname and
converted to 'http://test.txt' but this seems an acceptable trade off
and definitely better than trying to store a list of valid TLDs so
filenames and hostnames can be determined.

5 of 5 new or added lines in 1 file covered. (100.0%)

2388 of 2519 relevant lines covered (94.8%)

547.68 hits per line