944
97%
master: 97%

Ran 05 Feb 2017 08:12AM UTC

Jobs 2

Files 24

Run time 18s

Badge

Embed ▾

pending completion

Build # 944

Build Type

Pull #620

travis-ci

Committed by

web-flow

Commit Message

Fix memory hole while uploading 5G chunks

The call read(MAX_FILE_SIZE) will load the hole MAX_FILE_SIZE into
memory, which turns to be 5GB. That puts the system to a crawl.

Instead, the better way to go around this is to use streaming, copying
small chunks of memory in a loop until all bytes are transferred.
Python provides shutil.copyfileobj that saves you even writting the loop
explicitly.

Apart from that:
- xreadlines has been deperectaed for quite a while now:
  https://www.quantifiedcode.com/knowledge-base/maintainability/%60.xreadlines()%60%20deprecated/7lC2NACa
- Tox was not able to run pypy test env properly without the explicit
  dependencies on requests and nose.

Pull Request Pull Request #620: Fix memory hole while uploading 5G chunks

Run Details

6485 of 6706 relevant lines covered (96.7%)

0.97 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	99.92	0.0%	pyrax/object_storage.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	944.1	05 Feb 2017 08:12AM UTC	24	96.7	Travis Job 944.1
2	944.2	05 Feb 2017 08:12AM UTC	0		Travis Job 944.2

Source Files on build 944

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

rackspace / pyrax / 944
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 944

rackspace / pyrax / 944 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 944

rackspace / pyrax / 944
97%
master: 97%

README BADGES
x