18F / hubot-slack-github-issues / 409

Builds Branch Commit Type Ran Committer Via Coverage
409 master Merge pull request #49 from 18F/return-promises-from-tests Replace should.notify(done) with returned Promises push mbland travis-ci pending completion   set done
408 master Replace should.notify(done) with returned Promises I'd originally used `should.notify(done)` based on the advice from https://www.npmjs.com/package/chai-as-promised#working-with-non-promisefriendly-test-runners. However, returning the generated P... Pull #49 mbland travis-ci pending completion   set done
407 return-promises-from-tests Replace should.notify(done) with returned Promises I'd originally used `should.notify(done)` based on the advice from https://www.npmjs.com/package/chai-as-promised#working-with-non-promisefriendly-test-runners. However, returning the generated P... push mbland travis-ci pending completion   set done
406 master Merge pull request #48 from 18F/eslint Switch from JSHint to ESLint; address warnings push rogeruiz travis-ci pending completion   set done
405 master Switch from JSHint to ESLint; address warnings Pull #48 mbland travis-ci pending completion   set done
404 eslint Switch from JSHint to ESLint; address warnings push mbland travis-ci pending completion   set done
403 master Merge pull request #47 from 18F/client-protocol-test requestFactory assignment in Client constructors push msecret travis-ci pending completion   set done
402 master requestFactory assignment in Client constructors This is a follow-up to #46 to prevent a regression. Pull #47 mbland travis-ci pending completion   set done
401 client-protocol-test requestFactory assignment in Client constructors This is a follow-up to #46 to prevent a regression. push mbland travis-ci pending completion   set done
400 1.0.2 Bump to v1.0.2 Contains GitHubClient bug fix from #46. push mbland travis-ci pending completion   set done
399 master Bump to v1.0.2 Contains GitHubClient bug fix from #46. push mbland travis-ci pending completion   set done
398 master Merge pull request #46 from 18F/fix-github-client-bug Check for client.baseurl.protocol in GitHubClient push mbland travis-ci pending completion   set done
397 master Check for client.baseurl.protocol in GitHubClient This was causing the `makeApiCall` function to choose the `http` module every time, since `client.protocol` is undefined. In production, users were getting the error: `Protocol "https:" not suppor... Pull #46 mbland travis-ci pending completion   set done
396 fix-github-client-bug Check for client.baseurl.protocol in GitHubClient This was causing the `makeApiCall` function to choose the `http` module every time, since `client.protocol` is undefined. In production, users were getting the error: `Protocol "https:" not suppor... push mbland travis-ci pending completion   set done
395 1.0.1 Bump to v1.0.1 Includes entry point fix from #45. push mbland travis-ci pending completion   set done