nomad-coe / electronic-parsers

93%

LAST BUILD ON BRANCH develop

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 242-cp2k-parser-failing-at-process-id
• 274-add-support-for-md-to-cp2k
• 276-add-bandstructure-support-for-qe
• 289-add-workflows-to-gaussian-parser
• 318-harden-time-extraction
• JFRudzinski-patch-1
• JFRudzinski-patch-2
• add-parser-coverage-ai
• add-zenodo-doi
• add_author_jfrodlova
• ams-fix-np
• boolean-check-update
• bump_depedencies
• bump_mypy
• develop
• dynamic-version
• elk-eigs-quick-fix
• entry-point
• exciting-bse-workflow
• fix-ams
• fix-cp2k
• fix-exciting
• fix-file-parser
• fix-gaussian
• fix-gpaw
• fix-guassian
• fix-magres
• fix-parser-specs
• fix-quantity-types
• fix-siesta
• fix-vasp
• fix-yambo
• fix_cp2k_inp
• fix_magres_and_add_atom_labels
• gauss_chkpnt
• gauss_chkpnt_bs
• hotfix_vasp_xc
• link-qe-entries
• manifest-change
• nomad-release-fixes
• numpy-pint
• package
• parser-fixes
• parser-level
• patch_fhiaims_nelectrons
• pydanticv2
• release
• remove-cff-comments
• remove-menv
• remove_wannier90
• rspt-shell-parser
• ruff-patch
• type-mismatch
• unlink-parser-numpy-update
• unlink-parsers
• update
• update-hdf5
• update-netcdf4-dep
• update-pytest
• upgrade-netcdf4
• upgrade-numpy
• use-approx-for-float-compare
• v0.1.0
• v1.0
• v1.0.1
• v1.0.10
• v1.0.11
• v1.0.12
• v1.0.13
• v1.0.14
• v1.0.2
• v1.0.3
• v1.0.4
• v1.0.5
• v1.0.6
• v1.0.7
• v1.0.8
• v1.0.9
• vasp-h5-parser
• vasp_element_detection
• zenodo_prep

Build # 21594295648

Build Type

push

github

Committed by ondracka

Commit Message

OpenMX: corehole and empty atoms parsing fixes

- handle the empty atoms (no pseudo there and 0 atom number)
- the atom label doesn't need to follow the standard atomic symbols...
- fix hardcoded 19 in the pseudo version
- properly parse the code-specific atom labels
- fix the broken corehole parsing
- add tests for all of this

v2:
- fix regex
- use dict instead of list of string

Co-authored-by: Nathan Daelman <107392603+ndaelman-hu@users.noreply.github.com>

Run Details

40 of 43 new or added lines in 2 files covered. (93.02%)

23 existing lines in 1 file now uncovered.

36121 of 38886 relevant lines covered (92.89%)

0.93 hits per line