You are now the owner of this repo.

Teamwork / kommentaar
53%
master: 53%

Repo Added 17 Jan 2024 02:00PM UTC

Token Hl0IHChx7sdBtong96gTfQfrlaivub8Ak regen

Build 67 Last

Files 10

Badge

Embed ▾

LAST BUILD ON BRANCH refs/tags/v0.2.7
branch: SELECT

CHANGE BRANCH
x

Sync Branches

No branch selected

docker

enhancement/better-generic-support

enhancement/generic-types-map

enhancement/preinstall-kommentaar-docker

enums

feature/update-go-1.26

fix/cross-package-enum

fix/generics

fix/generics-support

fix/linter

fix/maptype-resolve-selectors-and-slices

generics

go-compiler

log-empty-tags

map-of-slice-additional-properties

maps

master

refs/tags/v0.1.10

refs/tags/v0.1.11

refs/tags/v0.1.9

refs/tags/v0.2.0

refs/tags/v0.2.1

refs/tags/v0.2.2

refs/tags/v0.2.3

refs/tags/v0.2.4

refs/tags/v0.2.5

refs/tags/v0.2.6

refs/tags/v0.2.7

run-output-opt

Committed 23 Apr 2026 05:02PM UTC coverage: 53.142% (+0.3%) from 52.863%

Build # 24848127074

Build Type

push

github

Committed by

web-flow

Commit Message

Fix enum variations not resolved for cross-package enum types (#110)

When a field annotated with {enum} has a type from another package
(e.g. `pkg.SomeType`), getEnumVariations was never called with the
correct type name. The SelectorExpr branch called canonicalType which
resolved the type to its underlying primitive and then jumped back via
goto start; the re-entry then called getEnumVariations with the
primitive name ("string") rather than the original type name
("SomeType"), so no constants were ever matched.

Fix: call getEnumVariations with the original pkg and type name before
executing goto start in the SelectorExpr branch, mirroring what the
Ident branch already does.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

13 of 18 new or added lines in 1 file covered. (72.22%)

1 existing line in 1 file now uncovered.

1167 of 2196 relevant lines covered (53.14%)

41.35 hits per line

Relevant lines Covered

2196 RELEVANT LINES 1167 COVERED LINES

41.35 HITS PER LINE

Source Files on master

Recent builds

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
24848127074	refs/tags/v0.2.7	Fix enum variations not resolved for cross-package enum types (#110) When a field annotated with {enum} has a type from another package (e.g. `pkg.SomeType`), getEnumVariations was never called with the correct type name. The SelectorExpr branch ...	push	23 Apr 2026 05:04PM UTC	web-flow	github	53.14
24848102737	master	Fix enum variations not resolved for cross-package enum types (#110) When a field annotated with {enum} has a type from another package (e.g. `pkg.SomeType`), getEnumVariations was never called with the correct type name. The SelectorExpr branch ...	push	23 Apr 2026 05:03PM UTC	web-flow	github	53.14
24848096496	master	Merge pull request #108 from Teamwork/map-of-slice-additional-properties	push	23 Apr 2026 05:03PM UTC	web-flow	github	52.86
24848043446	fix/cross-package-enum	Fix enum variations not resolved for cross-package enum types When a field annotated with {enum} has a type from another package (e.g. `pkg.SomeType`), getEnumVariations was never called with the correct type name. The SelectorExpr branch called ...	Pull #110	23 Apr 2026 05:02PM UTC	shane-tw	github	53.28
24847921383	map-of-slice-additional-properties	Normalise map value type before primitive check `resolveMap` compared the raw Go type name against the JSON-schema primitive set, so `int`/`bool`/`float64` failed the check and fell through to an open-object fallback. Run `JSONSchemaType` first s...	Pull #108	23 Apr 2026 04:59PM UTC	seanogdev	github	52.86
24847908442	master	Merge pull request #109 from Teamwork/fix/maptype-resolve-selectors-and-slices	push	23 Apr 2026 04:59PM UTC	web-flow	github	53.0
24847903587	fix/cross-package-enum	Fix enum variations not resolved for cross-package enum types When a field annotated with {enum} has a type from another package (e.g. `pkg.SomeType`), getEnumVariations was never called with the correct type name. The SelectorExpr branch called ...	Pull #110	23 Apr 2026 04:59PM UTC	shane-tw	github	52.29
24847670430	fix/cross-package-enum	Fix enum variations not resolved for cross-package enum types When a field annotated with {enum} has a type from another package (e.g. `pkg.SomeType`), getEnumVariations was never called with the correct type name. The SelectorExpr branch called ...	Pull #110	23 Apr 2026 04:53PM UTC	shane-tw	github	52.29
24846599413	map-of-slice-additional-properties	Normalise map value type before primitive check `resolveMap` compared the raw Go type name against the JSON-schema primitive set, so `int`/`bool`/`float64` failed the check and fell through to an open-object fallback. Run `JSONSchemaType` first s...	Pull #108	23 Apr 2026 04:28PM UTC	seanogdev	github	51.87
24845660006	fix/maptype-resolve-selectors-and-slices	Collapse redundant MapType branches in fieldToSchema The SelectorExpr case used `t == ""` / `t != ""` gating around the canonicalType check, then re-tested `t` again afterwards. Collapsing both into a single early-return via applyMapType keeps be...	Pull #109	23 Apr 2026 04:07PM UTC	seanogdev	github	53.0

See All Builds (67)

Badge your Repo: kommentaar

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.

Embed ▾

Refresh