You are now the owner of this repo.

umputun / remark42
84%

DEFAULT BRANCH: master
Repo Added
Token eqCnozHBf54UGZ8kokrZbOvkEkhZY23aj regen
Build 1612 Last
Files 51
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 84.247% (+0.1%) from 84.126%
24600086020

push

github

web-flow 
test: use testing/synctest to eliminate wall-clock sleeps (#2048)

Go 1.25's testing/synctest package (GA) provides a fake clock bubble
for deterministic goroutine and timer testing. Convert tests that
waited on real-time durations to use synctest, removing most wall-clock
time.Sleep workarounds.

Converted (11 tests, 9 files):
- notify/notify_test.go — all tests, replaced 17 time.Sleep(110ms) with synctest.Wait()
- store/service/service_test.go — VoteSameIPWithDuration, UserReplies, submitImages,
  ResubmitStagingImages, deleteImagesOnCommentDelete
- store/image/{image,bolt_store}_test.go — Cleanup, Submit, SubmitDelay
- store/engine/bolt_test.go — FlagListBlocked
- providers/telegram_test.go — DispatchTelegramUpdates
- migrator/backup_test.go — TestBackup_Do
- _example/memory_store/accessor/data_test.go — FlagListBlocked

Simplifications along the way:
- notify/notify_mock.go: dropped the 10ms time.After delay and
  ctx.Done select in MockDest — the artificial I/O simulation is
  pointless and blocked synctest.Wait from draining the queue
- Removed three dead-code time.Sleep(1s) calls in EditCommentDurationFailed,
  EditCommentAdmin, and Info tests: prepopulated comments from 2017
  already exceed any EditDuration/ReadOnlyAge under real clock, making
  the sleeps meaningless
- UserReplies: replaced the Eventually+Sleep+mutex polling with a
  direct time.Sleep under fake clock

Skipped (incompatible with synctest):
- fs_store_test.go: relies on OS file mtime (real wall clock)
- rss_test.go: needs real wall-clock second boundary for pubDate
- admin/rest_private/rest_public tests: httptest network I/O
- cmd/server_test.go: real HTTP server startup polling

Notes on quirks encountered:
- synctest.Wait() does NOT advance fake time, contrary to what one
  might expect. It only returns once all other bubble goroutines are
  durably blocked. To advance the fake clock, the test goroutine must
  itself call time.Sleep
- BoltDB keys the "last" bucket by commen... (continued)

6241 of 7408 relevant lines covered (84.25%)

34.51 hits per line

Relevant lines Covered
7408 RELEVANT LINES 6241 COVERED LINES
34.51 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24600086020 master test: use testing/synctest to eliminate wall-clock sleeps (#2048) Go 1.25's testing/synctest package (GA) provides a fake clock bubble for deterministic goroutine and timer testing. Convert tests that waited on real-time durations to use synctest... push web-flow github
84.25
24599629279 master fix(api): drop QR-write nolint dup + trim dead `..` check Address PR #2045 review (umputun): * The //nolint:gosec on telegramQrCtrl's w.Write(png) was byte-identical to the same line in #2044 (gosec-rule restoration). Drop it here so the two... push umputun github
84.13
24596866617 security-pr-a-path-traversal fix(api): drop QR-write nolint dup + trim dead `..` check Address PR #2045 review (umputun): * The //nolint:gosec on telegramQrCtrl's w.Write(png) was byte-identical to the same line in #2044 (gosec-rule restoration). Drop it here so the two... Pull #2045 paskal github
84.34
24596576498 security-pr-a-path-traversal fix(api): reject control characters in /picture URL segments Address PR #2045 review feedback (Copilot #2045-1). The previous safePictureSegment allowed CR/LF/TAB through, so a request such as GET /api/v1/picture/dev%0Auser/abc.png would inject l... Pull #2045 paskal github
84.36
24596546017 security-fixes-2026-04 fix(safehttp): clone http.DefaultTransport, sharpen Image.Transport contract Address review feedback on PR #2044. safehttp.Transport(): * Clone http.DefaultTransport instead of building a bare &http.Transport{} so Proxy, ForceAttemptHTTP2, Max... Pull #2044 paskal github
84.47
24592734878 master test(store): use time.UTC in test fixtures to be timezone-agnostic The store tests stored timestamps with time.Local in their fixtures and asserted equality against returned values that the engine round-trips through UTC. assert.Equal compares zo... push umputun github
84.13
24592686760 master fix(api): require explicit ?site= in matchSiteID middleware matchSiteID guarded most authenticated and admin routes with `if siteID != "" && user.SiteID != siteID`. Dropping the ?site= query parameter made the check no-op and any authenticated us... push umputun github
84.16
24591322614 tests/synctest-refactor test: use testing/synctest to eliminate wall-clock sleeps Go 1.25's testing/synctest package (GA) provides a fake clock bubble for deterministic goroutine and timer testing. Convert tests that waited on real-time durations to use synctest, removi... Pull #2048 paskal github
84.35
24582579682 security-fixes-2026-04 chore(lint): cap multipart upload size and suppress remaining gosec G70x Address all golangci-lint v2.10.1 (CI's version) findings: * Add http.MaxBytesReader hard cap to ParseMultipartForm sites in rest_private.savePictureCtrl (32MB) and api/m... Pull #2044 paskal github
84.46
24582473426 security-pr-d-tz-tests test(store): use time.UTC in test fixtures to be timezone-agnostic The store tests stored timestamps with time.Local in their fixtures and asserted equality against returned values that the engine round-trips through UTC. assert.Equal compares zo... Pull #2047 paskal github
84.35
See All Builds (1571)