se-edu / addressbook-level4 / 4955

Builds Branch Commit Type Ran Committer Via Coverage
4955 new-rebased build.gradle: upgrade shadow plugin to 4.0.4 The current shadow plugin we are using is 2.0.3, which mismatches Gradle 5.2.1 and gives the error below: Method com/github/jengelman/gradle/plugins/shadow/internal/DependencyFileCollection.getBuildDep... Pull #980 web-flow travis-ci pending completion   set done
4954 new-rebased Gradle wrapper: upgrade to Gradle 5.2.1 We are currently using Gradle 4.8.1 as our default wrapper, which is a version before JDK 11 comes. Gradle 5.2.1 has been announced for a while and it gives better support for JDK11.[1] As we are going to... Pull #980 web-flow travis-ci pending completion   set done
4952 new-rebased build.gradle: remove wrapper task Since Gradle 4.8 overriding built-in tasks, such as the `wrapper` task, has been deprecated and since Gradle 5.0 would actually produce an error: > Cannot add task 'wrapper' as a task with that name already exis... Pull #980 web-flow travis-ci pending completion   set done
4951 master diagrams: restore original LogicComponentSequenceDiagram.pptx The corresponding source pptx file for SDForDeletePerson.png is HighLevelSequenceDiagrams.pptx. However, when SDForDeletePerson.png was updated in 89ec0382 (Address book storage: migr... push pyokagan travis-ci pending completion   set done
4950 fix-docs diagrams: restore original LogicComponentSequenceDiagram.pptx The corresponding source pptx file for SDForDeletePerson.png is HighLevelSequenceDiagrams.pptx. However, when SDForDeletePerson.png was updated in 89ec0382 (Address book storage: migr... Pull #978 web-flow travis-ci pending completion   set done
4949 fix-docs diagrams: restore original LogicComponentSequenceDiagram.pptx The corresponding source pptx file for SDForDeletePerson.png is HighLevelSequenceDiagrams.pptx. However, when SDForDeletePerson.png was updated in 89ec0382 (Address book storage: migr... Pull #978 web-flow travis-ci pending completion   set done
4948 fix-docs diagrams: restore original LogicComponentSequenceDiagram.pptx The corresponding source pptx file for SDForDeletePerson.png is HighLevelSequenceDiagrams.pptx. However, when SDForDeletePerson.png was updated in 89ec0382 (Address book storage: migr... Pull #978 web-flow travis-ci pending completion   set done
4947 fileUtilTest_windowsPath FileUtilTest: Add test for Windows path Currently, FileUtilTest#isValidPath() only tests for isValidPath for a linux path. However, our users can also develop and use AB4 on a Windows PC. To provide assurance that our FileUtil#isValidPath(String)... Pull #976 web-flow travis-ci pending completion   set done
4946 fileUtilTest_windowsPath FileUtilTest: Add test for Windows path Currently, FileUtilTest#isValidPath() only tests for isValidPath for a linux path. However, our users can also develop and use AB4 on a Windows PC. To provide assurance that our FileUtil#isValidPath(String)... Pull #976 web-flow travis-ci pending completion   set done
4945 migration_junit5 Build.gradle: Remove JUnit 4 libraries Currently, we use a mix of both JUnit 4 and 5 libraries, using JUnit Vintage to maintain compatibility with JUnit 4 tests. After migrating all tests to JUnit 5, we no longer need these libraries to support ... Pull #959 web-flow travis-ci pending completion   set done
4944 migration_junit5 Build.gradle: Remove JUnit 4 libraries Currently, we use a mix of both JUnit 4 and 5 libraries, using JUnit Vintage to maintain compatibility with JUnit 4 tests. After migrating all tests to JUnit 5, we no longer need these libraries to support ... Pull #959 web-flow travis-ci pending completion   set done
4943 fileUtilTest_windowsPath FileUtilTest: Add test for Windows path Currently, FileUtilTest#isValidPath() only tests for isValidPath for a linux path. However, our users can also develop and use AB4 on a Windows PC. To provide assurance that our FileUtil#isValidPath(String)... Pull #976 web-flow travis-ci pending completion   set done
4942 stringUtilTest_rename StringUtilTest: Rename test method name Currently, StringUtilTest has a method named isUnsignedPositiveInteger. However, the method tested is actually named isNonZeroUnsignedInteger. This can cause confusion in the naming. It appears that the te... Pull #975 web-flow travis-ci pending completion   set done
4941 stringUtilTest_rename StringUtilTest: Rename test method name Currently, StringUtilTest has a method named isUnsignedPositiveInteger. However, the method tested is actually named isNonZeroUnsignedInteger. This can cause confusion in the naming. It appears that the te... Pull #975 web-flow travis-ci pending completion   set done
4940 migration_junit5 ClockRule: Migrate to ClockExtension Currently, we use ClockRule to implement a clock for unit testing. Rules are part of JUnit 4, and have been replaced by extensions in JUnit 5. As we migrate to JUnit 5, we should update ClockRule to follow th... Pull #959 web-flow travis-ci pending completion   set done