trotzig / diffux / 212

Builds Branch Commit Type Ran Committer Via Coverage
212 master Add manual migration for snapshot diffs My previous commit (862b6a3) moved the diff-related fields from the snapshot model to the new snapshot_diff model. This script will transfer the data. Run this from a terminal: bundle exec rails runne... push trotzig travis-ci pending completion   set done
211 master Update rspec-core 2.14.7 -> 2.14.8 Change-Id: I72e6180fa push lencioni travis-ci pending completion   set done
210 master Update phantomjs gem 1.9.2.1 -> 1.9.7.0 Change-Id: If1b4e31ec push lencioni travis-ci pending completion   set done
205 better-nav-scroll Only scroll when necessary on keyboard navigation This commit replaces the previous usage of the native JS function `scrollIntoView` with a jQuery solution instead. The new solution: - Only scrolls when the focused element is hidden. - Keeps 1/4... push trotzig travis-ci pending completion   set done
204 master Revert side-scroll for "In review" panel The "In review" panel on a snapshot page used to have horizontal scrolling to save space. It was hard to make keyboard navigation to work with this as `scrollIntoFocus` didn't make the currently highlighte... push trotzig travis-ci pending completion   set done
203 better-nav-scroll Only scroll when necessary on keyboard navigation This commit replaces the previous usage of the native JS function `scrollIntoView` with a jQuery solution instead. The new solution: - Only scrolls when the focused element is hidden. - Keeps 1/4... push trotzig travis-ci pending completion   set done
202 better-nav-scroll Only scroll when necessary on keyboard navigation This commit replaces the previous usage of the native JS function `scrollIntoView` with a jQuery solution instead. The new solution: - Only scrolls when the focused element is hidden. - Keeps 1/4... push trotzig travis-ci pending completion   set done
201 master Speed up snapshot card transitions The default transition duration for the .thumbnail class in Bootstrap is 200ms, which feels too slow when using keyboard shortcuts. This commit makes these twice as fast, just on the border of what feels "instan... push lencioni travis-ci pending completion   set done
200 master Prepend underscores to SCSS "partials" This is a signal to developers that these files are not referenced by themselves, and may also be used in the asset compilation process to avoid precompiling these assets by themselves unnecessarily. Change... push lencioni travis-ci pending completion   set done
199 master Add focusable context to "In review" panel when reviewing snapshots This prevents the panel heading from scrolling out of the viewport. In service of #13. Change-Id: I2146931d0 push lencioni travis-ci pending completion   set done
198 master Allow keyboard focusable elements to have a context When using keyboard shortcuts to focus elements, we scroll the element into the viewport. On some pages, such as when viewing the shapshots on a project, there is important context above the foc... push lencioni travis-ci pending completion   set done
197 master Make sweeps table keyboard focusable In service of #13. Change-Id: I43a359e20 push lencioni travis-ci pending completion   set done
196 master Prevent [ and ] from scrolling to focused Since [ and ] simulate what j and k do, followed by o, we were seeing the viewport being scrolled around before clicking the link, causing a weird and janky experience. Moving the scrolling behavior into ... push lencioni travis-ci pending completion   set done
195 master Scroll to focused element when using keyboard shortcuts When using the keyboard to navigate between focusable elements, the focusable element you end up focusing may end up being outside of the current viewport. This makes this feature difficult ... push lencioni travis-ci pending completion   set done
194 master Only click links if they exist Some of our keyboard shortcuts assumed that a link was available to click. If there was not a link, an error would be logged along the lines of "Cannot call method 'click' of undefined". This commit prevents this er... push lencioni travis-ci pending completion   set done